IBX-3987: Go to top button overlaps with pagination in subitems list when using grid view #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
reviewed
Oct 12, 2022
|
|
||
| currentBackToTopAnchorHeight = entries[0].target.clientHeight; | ||
|
|
||
| toggleBackToTopBtnText(backToTopScrollContainer); |
There was a problem hiding this comment.
toggle in the name of the function suggests that this function will show/hide back-to-top-button on resize event. But it is actually checking inside whether it should do this which is not intuitive.
lucasOsti
approved these changes
Oct 12, 2022
dew326
approved these changes
Oct 12, 2022
Gengar-i
approved these changes
Oct 12, 2022
tischsoic
approved these changes
Oct 12, 2022
…when using grid view
GrabowskiM
force-pushed
the
IBX-3987-adjust-back-to-top-button-on-container-height-change
branch
from
3e6dd4e
to
d53e0b4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
katarzynazawada
approved these changes
Oct 14, 2022
dew326
deleted the
IBX-3987-adjust-back-to-top-button-on-container-height-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)