IBX-4213: Missing hovers on icons #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
reviewed
Nov 9, 2022
| @@ -10,15 +10,31 @@ | |||
| border-bottom: calculateRem(1px) solid transparent; | |||
| transition: all $ibexa-admin-transition-duration $ibexa-admin-transition; | |||
|
|
|||
| .ibexa-icon--toggle { | |||
| position: absolute; | |||
There was a problem hiding this comment.
Do we need this to have position absolute?
| @@ -30,7 +30,7 @@ | |||
| {% if is_password_input %} | |||
| <button | |||
| type="button" | |||
| class="btn ibexa-input-text-wrapper__action-btn ibexa-input-text-wrapper__action-btn--password-toggler" | |||
| class="btn ibexa-btn ibexa-btn--no-text ibexa-input-text-wrapper__action-btn ibexa-input-text-wrapper__action-btn--password-toggler" | |||
There was a problem hiding this comment.
Personally, I don't think this should be ibexa-btn.
There was a problem hiding this comment.
Discussed in private, Gosia also confirmed, that this button should behave as ghost (and have same changes as ghost, if such occured in future)
|
Kudos, SonarCloud Quality Gate passed!
|
Gengar-i
approved these changes
Nov 14, 2022
tischsoic
approved these changes
Nov 14, 2022
dew326
approved these changes
Nov 17, 2022
lucasOsti
approved these changes
Nov 18, 2022
katarzynazawada
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)