IBX-4277: [UDW] Tooltips from left menu aren't visible #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gengar-i
approved these changes
Nov 9, 2022
lucasOsti
approved these changes
Nov 10, 2022
dew326
approved these changes
Nov 14, 2022
tischsoic
approved these changes
Nov 14, 2022
katarzynazawada
requested changes
Nov 17, 2022
There was a problem hiding this comment.
Tooltips are not visible when switching to Bookmark tab. They only appear when you click on an item, see https://recordit.co/fGGmcvo2bO
GrabowskiM
force-pushed
the
IBX-4277-udw-selector-tooltips
branch
from
c4e21b4
to
501673a
Compare
tischsoic
reviewed
Nov 22, 2022
| @@ -35,7 +43,14 @@ const TabSelector = () => { | |||
| }); | |||
|
|
|||
| return ( | |||
| <div className={className} key={tab.id} onClick={onClick} title={tab.label}> | |||
| <div | |||
| ref={selectorItemTooltipCallbackRef} | |||
There was a problem hiding this comment.
Probably this would also work 🤔
Suggested change
| ref={selectorItemTooltipCallbackRef} | |
| ref={ibexa.helpers.tooltips.parse} |
tischsoic
approved these changes
Nov 22, 2022
| @@ -159,11 +167,13 @@ | |||
| bootstrap.Tooltip.getOrCreateInstance(tooltipNode).hide(); | |||
| } | |||
| }; | |||
|
|
|||
| observer.observe(doc.querySelector('body'), observerConfig); | |||
| const observe = (baseElement = doc.querySelector('body')) => { | |||
There was a problem hiding this comment.
Maybe it would be good to have the same default value as in parse? 🤔
Suggested change
| const observe = (baseElement = doc.querySelector('body')) => { | |
| const observe = (baseElement = doc) => { |
Gengar-i
approved these changes
Nov 23, 2022
dew326
approved these changes
Nov 23, 2022
tischsoic
approved these changes
Nov 23, 2022
lucasOsti
approved these changes
Nov 23, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
katarzynazawada
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)