Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-4327: Content airtime settings modal design #670

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Dec 20, 2022

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-4327
Bug fix? bug
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Added css for confirmDate plugin for flatpickr
Requires ibexa/admin-ui-assets#14
Here is built version of assets: ibexa/admin-ui-assets#15

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM force-pushed the IBX-4327-airtime-modal-design-fixes branch 2 times, most recently from 559a0b1 to 176bc86 Compare January 10, 2023 12:09
@bogusez bogusez self-assigned this Jan 13, 2023
@bogusez
Copy link
Contributor

bogusez commented Jan 16, 2023

Regression tests passed:
ibexa/experience#128
ibexa/commerce#198

@GrabowskiM GrabowskiM force-pushed the IBX-4327-airtime-modal-design-fixes branch from dca558f to 9a53778 Compare January 16, 2023 10:03
@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dew326 dew326 merged commit bb1bb37 into 4.3 Feb 2, 2023
@dew326 dew326 deleted the IBX-4327-airtime-modal-design-fixes branch February 2, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants