Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5018: Unified 'Create' buttons in Content Types and Content Type Groups lists #720

Merged
merged 1 commit into from
Mar 10, 2023
Merged

IBX-5018: Unified 'Create' buttons in Content Types and Content Type Groups lists #720

merged 1 commit into from
Mar 10, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Mar 1, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5018
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Updated Content Type list template to match Content Type Group list template when it comes to the 'Create' buttons.

After:
image

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 requested a review from a team March 1, 2023 16:47
@barw4 barw4 self-assigned this Mar 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2023 •
edited

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza requested a review from a team March 2, 2023 07:34
@micszo micszo self-assigned this Mar 10, 2023
@micszo micszo mentioned this pull request Mar 10, 2023
Closed
micszo
micszo approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.3.6-dev.

@micszo micszo removed their assignment Mar 10, 2023
@barw4 barw4 changed the base branch from 4.3 to 4.4 March 10, 2023 14:50
@barw4 barw4 changed the base branch from 4.4 to 4.3 March 10, 2023 14:50
@barw4 barw4 changed the base branch from 4.3 to 4.4 March 10, 2023 14:51
@ViniTou ViniTou merged commit b154f6d into 4.4 Mar 10, 2023
@ViniTou ViniTou deleted the ibx-5018-unify-create-buttons branch March 10, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

@barw4 barw4

Labels
Improvement QA approved Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@barw4 @micszo @ViniTou @konradoboza @mikadamczyk @Nattfarinn @dew326