IBX-5369: Fixed admin notifications request being queued too often #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
lucasOsti
requested changes
Mar 22, 2023
| @@ -169,6 +169,10 @@ | |||
|
|
|||
| modal.querySelectorAll(SELECTOR_MODAL_RESULTS).forEach((link) => link.addEventListener('click', handleModalResultsClick, false)); | |||
|
|
|||
| getNotificationsStatus(); | |||
| global.setInterval(getNotificationsStatus, INTERVAL); | |||
| const loop = function loop() { | |||
There was a problem hiding this comment.
I think the variable name loop is too generic
Gengar-i
approved these changes
Mar 22, 2023
GrabowskiM
approved these changes
Mar 22, 2023
dew326
approved these changes
Mar 22, 2023
lucasOsti
approved these changes
Mar 22, 2023
tischsoic
changed the title
tischsoic
force-pushed
the
fixed-notification-requests-queue
branch
from
0f3952f
to
c1d9f08
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jwibexa
approved these changes
Mar 24, 2023
|
Merged up:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
setIntervalfunction call withsetTimeout.This is done to prevent notification requests being queued regardless of the state of the previous request. For development environments, especially with multiple tabs open, this can cause local server to become overwhelmed by long-running requests, especially when clearing cache or performing other operations which require application container to be recompiled, like changing configuration.
Checklist:
$ composer fix-cs)