-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-5293: Added event dispatcher in default success handler #215
Merged
mikadamczyk
merged 3 commits into
main
from
ibx-5293-added-dispatcher-for-url-resolving
Mar 27, 2023
Merged
IBX-5293: Added event dispatcher in default success handler #215
mikadamczyk
merged 3 commits into
main
from
ibx-5293-added-dispatcher-for-url-resolving
Mar 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2023
kisztof
approved these changes
Mar 14, 2023
konradoboza
reviewed
Mar 14, 2023
src/lib/MVC/Symfony/Security/Authentication/DefaultAuthenticationSuccessHandler.php
Outdated
Show resolved
Hide resolved
src/lib/MVC/Symfony/Security/Authentication/DetermineTargetUrlEvent.php
Outdated
Show resolved
Hide resolved
alongosz
requested changes
Mar 14, 2023
src/lib/MVC/Symfony/Security/Authentication/DefaultAuthenticationSuccessHandler.php
Outdated
Show resolved
Hide resolved
konradoboza
approved these changes
Mar 15, 2023
alongosz
approved these changes
Mar 15, 2023
Kudos, SonarCloud Quality Gate passed!
|
Steveb-p
approved these changes
Mar 15, 2023
tomaszszopinski
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP commerce 4.5.
mikadamczyk
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5
Working with custom success handler is troublesome if you do not want to define it explicite in security configuration - and we do not want to do it, as it adds more complexity on client side. What's more we had problems with constructor signature change in the past - that's why I decided to drop custom handler inside adminUI package (ibexa/admin-ui#732) and instead of it emit event that can be modified in any package (corporate-account in mind) an based on that could handle redirects based on external logic.
Two extra things done:
I have moved setting
default_target_path
based on config resolver from set method todetermineTargetUrl
one.setConfigResolver
didnt actually set it config resolver.setOptions
(which is defined in Symfony Security Extension) - meaning that just after setting default_target_path from resolver it was overriden by defaults.I have decided to use now working default_page configuration to set default page for adminUI, hence:
ibexa/recipes-dev#57
Checklist:
$ composer fix-cs
).@ibexa/engineering
).