Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5293: Added event dispatcher in default success handler #215

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Mar 13, 2023

Question Answer
JIRA issue IBX-5293
Type feature/bug/improvement
Target Ibexa version v4.5
BC breaks no

Working with custom success handler is troublesome if you do not want to define it explicite in security configuration - and we do not want to do it, as it adds more complexity on client side. What's more we had problems with constructor signature change in the past - that's why I decided to drop custom handler inside adminUI package (ibexa/admin-ui#732) and instead of it emit event that can be modified in any package (corporate-account in mind) an based on that could handle redirects based on external logic.

Two extra things done:

I have moved setting default_target_path based on config resolver from set method to determineTargetUrl one.

  • first of all, setConfigResolver didnt actually set it config resolver.
  • that method was called before setOptions (which is defined in Symfony Security Extension) - meaning that just after setting default_target_path from resolver it was overriden by defaults.

I have decided to use now working default_page configuration to set default page for adminUI, hence:
ibexa/recipes-dev#57

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@konradoboza konradoboza requested a review from a team March 14, 2023 08:07
@alongosz alongosz requested a review from a team March 14, 2023 12:04
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 4.5.

@mikadamczyk mikadamczyk merged commit 7c0b3d0 into main Mar 27, 2023
@mikadamczyk mikadamczyk deleted the ibx-5293-added-dispatcher-for-url-resolving branch March 27, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants