Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5293: Replaced custom redirect success handler with listener #732

Merged
merged 2 commits into from
Mar 27, 2023
Merged

IBX-5293: Replaced custom redirect success handler with listener #732

merged 2 commits into from
Mar 27, 2023

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Mar 13, 2023 •
edited

Question Answer
JIRA issue IBX-5293
Bug fix? no
New feature? yes
BC breaks? yes/no
Tests pass? yes
Doc needed? no
License GPL-2.0

Description in:
ibexa/core#215

🟢 Behat Build with dependencies https://github.com/ibexa/admin-ui/actions/runs/4436745000/jobs/7785562255?pr=732 🟢

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ViniTou ViniTou mentioned this pull request Mar 13, 2023
Merged
6 tasks
@ViniTou ViniTou requested a review from a team March 13, 2023 15:16
@konradoboza konradoboza requested a review from a team March 14, 2023 08:11
@konradoboza konradoboza requested a review from a team March 16, 2023 11:03
@ViniTou ViniTou changed the title IBX-5293: Replaced custom redirect success handler with listener [NO MERGE] IBX-5293: Replaced custom redirect success handler with listener Mar 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou changed the title [NO MERGE] IBX-5293: Replaced custom redirect success handler with listener IBX-5293: Replaced custom redirect success handler with listener Mar 16, 2023
tomaszszopinski
tomaszszopinski approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 4.5.

@mikadamczyk mikadamczyk merged commit 0fab524 into main Mar 27, 2023
@mikadamczyk mikadamczyk deleted the ibx-5293-success-handlers branch March 27, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisztof kisztof kisztof approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ViniTou @kisztof @mikadamczyk @konradoboza @tomaszszopinski @Nattfarinn @dew326