-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-5705: Added support for authentication via GuardAuthenticationProvider #244
Conversation
@@ -73,6 +74,13 @@ public function process(ContainerBuilder $container) | |||
[$permissionResolverRef] | |||
); | |||
|
|||
$guardAuthenticationProviderDef = $container->findDefinition('security.authentication.provider.guard'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you can possibly decorate this service instead of extending it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the Way of the Core. Or we can consider it as a tribute to Andre.
But sure, we could. WDYT @alongosz ?
As for my opinion, I think it is not perfect but it is good to have all security services defined in one place. Less prone to error that could otherwise be potentially catastrophic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the Way of the Core. Or we can consider it as a tribute to Andre.
This is the way of legacy.
But sure, we could. WDYT @alongosz ?
As for my opinion, I think it is not perfect but it is good to have all security services defined in one place. Less prone to error that could otherwise be potentially catastrophic.
The issue is that the way it works now is a technical debt. If you can decorate it, please do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos, SonarCloud Quality Gate passed!
|
v4.6
Required by OAuth2 Authentication. Without it even if we successfully authenticate user with JWT token on Symfony security layer, we need to provide user for our PermissionResolver.
Checklist:
$ composer fix-cs
).@ibexa/engineering
).