Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7636: Prevented caching content preview response #331

Merged
merged 2 commits into from
Feb 19, 2024
Merged

IBX-7636: Prevented caching content preview response #331

merged 2 commits into from
Feb 19, 2024

Conversation

papcio122
Copy link
Contributor

@papcio122 papcio122 commented Feb 7, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7636
Type bug
Target Ibexa version v4.5
BC breaks no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@papcio122 papcio122 changed the title IBX-7636 added CacheControl header to preview content response in order… IBX-7636 added CacheControl header to preview content response in order to prevent caching preview Feb 7, 2024
@papcio122 papcio122 requested a review from a team February 7, 2024 09:25
@alongosz alongosz changed the title IBX-7636 added CacheControl header to preview content response in order to prevent caching preview IBX-7636: Prevented caching content preview response Feb 7, 2024
@papcio122 papcio122 added Bug Something isn't working Ready for review labels Feb 7, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@papcio122 papcio122 requested a review from webhdx February 7, 2024 10:48
@alongosz alongosz requested a review from a team February 7, 2024 10:54
@konradoboza konradoboza requested a review from a team February 7, 2024 10:56
@bogusez bogusez self-assigned this Feb 19, 2024
This was referenced Feb 19, 2024
Closed
Closed
Closed
@alongosz alongosz merged commit 4e5b883 into 4.5 Feb 19, 2024
21 checks passed
@alongosz alongosz deleted the IBX-7636_prevent-preview-ifram-caching branch February 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

@bogusez bogusez bogusez approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@bogusez bogusez

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@papcio122 @alongosz @webhdx @konradoboza @bogusez @mikadamczyk