Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Update to 4.6" doc improvements #2325

Merged
merged 16 commits into from Apr 3, 2024
Merged

"Update to 4.6" doc improvements #2325

merged 16 commits into from Apr 3, 2024

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Mar 8, 2024

Things done:

  1. I've added mentions that 4.6 is the latest LTS - and that it's worth updating to it
  2. Included changes from IBX-7865: Added Recent Activity Dashboard block migration to upgrade procedure #2321 - so that everything is in one PR
  3. Mentioned that Node 18 is now required - it's a change between 4.5 and 4.6 that (from the feedback I've received) is easy to miss in the Requirements page and causes issues during update
  4. Mentions the OSS scripts if access to ibexa/installer is missing
  5. Includes missing migrations from https://issues.ibexa.co/browse/IBX-7865
  6. Applied Vidar's feedback from https://issues.ibexa.co/browse/IBX-7785?focusedId=282255&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-282255
  7. For the image content type I mention the migration
  8. Applied feedback from https://issues.ibexa.co/browse/IBX-7910 - added the section from 4.1 update doc (https://doc.ibexa.co/en/latest/update_and_migration/from_4.1/update_from_4.1/#remove-node_modules-and-yarnlock)

@mnocon mnocon changed the title Update to 4.6 doc improvements "Update to 4.6" doc improvements Mar 8, 2024
@mnocon mnocon marked this pull request as ready for review March 11, 2024 07:43
Copy link
Contributor

@vidarl vidarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mentioned that we have updated bootstrap so you might need to do changes in your templates?
ref. https://getbootstrap.com/docs/5.0/migration/

mnocon and others added 8 commits March 26, 2024 00:55
Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
@mnocon mnocon force-pushed the upgrade-doc-follow-up branch 2 times, most recently from cba3d23 to 903cb0e Compare March 25, 2024 23:57
@mnocon
Copy link
Contributor Author

mnocon commented Mar 26, 2024

@adriendupuis the generic update page texts have been updated, I hope they are correct now

I've also added a note about dashboard migrations - e6e4cd2 (this is after internal discussion on Slack(

@mnocon mnocon merged commit 8be4031 into master Apr 3, 2024
4 checks passed
@mnocon mnocon deleted the upgrade-doc-follow-up branch April 3, 2024 12:02
mnocon added a commit that referenced this pull request Apr 3, 2024
* Updated Update page to take the latest LTS into account

* Applied update doc feedback

* Added Recent Activity Dashboard block migration to upgrade procedure

* Added missing Dashboard and Image Picker scripts

* Applied feedback from IBX-7910

* Added missing extension

* Added missing Dashboard migrations

* Removed param info

* Added missing filename

* Applied suggestions

Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>

* Applied suggestions from code review

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Update docs/update_and_migration/from_2.5/update_from_2.5.md

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Update docs/update_and_migration/update_ibexa_dxp.md

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Applied review suggestion

* Updated texts in the generic update page

* Added mention about customizing the Dashboard permissions

---------

Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
mnocon added a commit that referenced this pull request Apr 3, 2024
* Updated Update page to take the latest LTS into account

* Applied update doc feedback

* Added Recent Activity Dashboard block migration to upgrade procedure

* Added missing Dashboard and Image Picker scripts

* Applied feedback from IBX-7910

* Added missing extension

* Added missing Dashboard migrations

* Removed param info

* Added missing filename

* Applied suggestions

Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>

* Applied suggestions from code review

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Update docs/update_and_migration/from_2.5/update_from_2.5.md

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Update docs/update_and_migration/update_ibexa_dxp.md

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Applied review suggestion

* Updated texts in the generic update page

* Added mention about customizing the Dashboard permissions

---------

Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
mnocon added a commit that referenced this pull request Apr 3, 2024
* Updated Update page to take the latest LTS into account

* Applied update doc feedback

* Added Recent Activity Dashboard block migration to upgrade procedure

* Added missing Dashboard and Image Picker scripts

* Applied feedback from IBX-7910

* Added missing extension

* Added missing Dashboard migrations

* Removed param info

* Added missing filename

* Applied suggestions

Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>

* Applied suggestions from code review

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Update docs/update_and_migration/from_2.5/update_from_2.5.md

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Update docs/update_and_migration/update_ibexa_dxp.md

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Applied review suggestion

* Updated texts in the generic update page

* Added mention about customizing the Dashboard permissions

---------

Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
mnocon added a commit that referenced this pull request Apr 3, 2024
* Updated Update page to take the latest LTS into account

* Applied update doc feedback

* Added Recent Activity Dashboard block migration to upgrade procedure

* Added missing Dashboard and Image Picker scripts

* Applied feedback from IBX-7910

* Added missing extension

* Added missing Dashboard migrations

* Removed param info

* Added missing filename

* Applied suggestions

Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>

* Applied suggestions from code review

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Update docs/update_and_migration/from_2.5/update_from_2.5.md

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Update docs/update_and_migration/update_ibexa_dxp.md

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Applied review suggestion

* Updated texts in the generic update page

* Added mention about customizing the Dashboard permissions

---------

Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants