Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8493: Ibexa Experience Product guide #2448

Merged
merged 18 commits into from
Aug 9, 2024
Merged

IBX-8493: Ibexa Experience Product guide #2448

merged 18 commits into from
Aug 9, 2024

Conversation

julitafalcondusza
Copy link
Contributor

@julitafalcondusza julitafalcondusza commented Jul 29, 2024

Question Answer
JIRA Ticket (https://issues.ibexa.co/browse/IBX-8493)
Versions 4.6+
Edition Headless, Experience, Commerce

Ibexa Experience Product guide added in Developer documentation.

Preview: https://ez-systems-developer-documentation--2448.com.readthedocs.build/en/2448/ibexa_products/experience/

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of suggestions how I think we can expand some sections and include features that weren't mentioned so far, but overall I like it - and it's very promising!

docs/ibexa_products/editions.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I'd still introduce segmentation as something different from CDP (IBX-8493: Ibexa Experience Product guide #2448 (comment))
  2. ReadTheDocs build is failing and there are some minor issues

Don't mind the broken PHPStan build, I'm taking care of it (the code samples stopped being valid when we merged https://github.com/ibexa/admin-ui/pull/1313/files)

docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, but I trust you will know how to resolve this 😄

It looks very good now, thank you!

docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
docs/ibexa_products/experience.md Outdated Show resolved Hide resolved
@julitafalcondusza julitafalcondusza merged commit 8fbf438 into master Aug 9, 2024
4 of 5 checks passed
@julitafalcondusza julitafalcondusza deleted the IBX-8493 branch August 9, 2024 10:40
julitafalcondusza added a commit that referenced this pull request Aug 9, 2024
* Ibexa Experience PG - skeleton

* Content added

* Features table added, new content

* Linka added

* New content & fixes

* Table with features deleted

* Fixes

* Editions - link fixed

* Fixes

* xml files added

* Fixes after review

* xml file for ibexa_engage addeed

* ~Ibexa cloud pg link removed (will be added later)

* Updates

* Fix

* Fixes after doc review

* Variables removed from links

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants