Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7762: Fixed anchor in list #150

Merged
merged 5 commits into from
Mar 14, 2024
Merged

IBX-7762: Fixed anchor in list #150

merged 5 commits into from
Mar 14, 2024

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Mar 5, 2024

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7762
Bug/Improvement yes
New feature no
Target version 4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 self-assigned this Mar 5, 2024
@dew326 dew326 requested a review from GrabowskiM March 7, 2024 14:08
@Gengar-i Gengar-i self-requested a review March 11, 2024 11:39
@dew326 dew326 requested a review from GrabowskiM March 11, 2024 11:45
@katarzynazawada katarzynazawada mentioned this pull request Mar 13, 2024
Closed
katarzynazawada
katarzynazawada requested changes Mar 13, 2024
View reviewed changes
Copy link

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a regression in the appearance of the anchor icon in Page Builder
Screenshot 2024-03-13 at 13 03 40

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dew326 dew326 merged commit bcca58d into 4.5 Mar 14, 2024
19 of 21 checks passed
@dew326 dew326 deleted the anchor-list branch March 14, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dew326 @GrabowskiM @tischsoic @lucasOsti @katarzynazawada @Gengar-i @alongosz