[Composer] Added conflict with Symfony 5.2.6 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lserwatka
approved these changes
Mar 30, 2021
adamwojs
approved these changes
Mar 30, 2021
Steveb-p
approved these changes
Mar 30, 2021
mikadamczyk
approved these changes
Mar 30, 2021
|
@lserwatka can we merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 5.2.6 has been released yesterday and it contains a regression:
symfony/symfony#40618
It has been detected by our tests as well:
https://travis-ci.com/github/ezsystems/ezplatform/jobs/494701655
(screenshot: https://res.cloudinary.com/ezplatformtravis/image/upload/v1617084143/screenshots/6062beef4f6f1703756003-vendor_ezsystems_ezplatform-admin-ui_features_personas_subtreeeditor_feature_41_x3qfme.png)
If you want to reproduce it locally you can set up a project (Ibexa OSS/DXP 3.3.x) and configure it to use Symfony Proxy according to https://doc.ibexa.co/en/latest/guide/http_cache/#symfony-reverse-proxy - the same exception is shown.
The issue should be fixed in symfony/symfony#40619 , but it has not been released yet.
Lower versions of our product are not affected, as we limit Symfony version there (https://github.com/ezsystems/ezplatform/blob/3.2/composer.json#L143)
Checklist:
@ibexa/engineering).