Skip to content

[FrameworkBundle] dont access the container to configure http_cache #40619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

[FrameworkBundle] dont access the container to configure http_cache #40619

merged 1 commit into from
Mar 29, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40618
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Mar 29, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request Mar 29, 2021
Closed
alexander-schranz
alexander-schranz approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@alexander-schranz alexander-schranz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this fix and it did work with @sulu. Thank you 👍

This was referenced Mar 29, 2021
Closed
Merged
@chalasr
Copy link
Member

chalasr commented Mar 29, 2021

Thank you @nicolas-grekas.

@chalasr chalasr merged commit 87a67be into symfony:5.2 Mar 29, 2021
@aschempp aschempp mentioned this pull request Mar 29, 2021
Merged
@mnocon mnocon mentioned this pull request Mar 30, 2021
Merged
4 tasks
@jvasseur jvasseur mentioned this pull request Mar 30, 2021
Closed
@nicolas-grekas nicolas-grekas deleted the fwb-hc branch April 12, 2021 15:40
@fabpot fabpot mentioned this pull request May 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@chalasr chalasr chalasr approved these changes

+2 more reviewers

@aschempp aschempp aschempp approved these changes

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @chalasr @stof @aschempp @alexander-schranz @carsonbot