IBX-5027: Added logging exceptions for REST #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Feb 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
kisztof
approved these changes
Feb 6, 2023
ViniTou
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.4Our REST API does not log exceptions when they occur, making it harder to debug requests.
While it is possible to read stacktrace in th REST response, it is cumbersome and requires response to actually remain somewhere (which might not always be the case).
Instead, I suggest we log exceptions in a similar fashion as built-in Symfony's ErrorListener service does it.
Ideally, we would simply allow ErrorListener to run and log exceptions this way (it registers itself with priority 0 and -128, for logging and generating response respectively), but that would be a BC break on our side, because we would need to change several service priorities - which might mess up our users configurations, if they rely on us having exception listeners with specific priorities.
Currently:
I would expect to have instead:
TODO:
$ composer fix-cs).