IBX-2493: Added option to invite other users to DXP & register from invitation #35

ViniTou · 2022-04-14T14:10:23Z

Question	Answer
Tickets	IBX-2493
Bug fix?	no
New feature?	yes
BC breaks?	no
Tests pass?	yes/no
Doc needed?	yes
License	GPL-2.0

Whats here:

User content type configurable by SA (based on: Made the user registration content type configurable #12)
Creation of SA based invitations with targets for user groups, roles, and roles limitations.
New policy & limitation to restrict who can invite who and where
Consuming invitations

Additional PRs:
ibexa/content-forms#29
ibexa/admin-ui#396

Checklist:

Implement tests
Coding standards ($ composer fix-cs)

src/bundle/DependencyInjection/Configuration/Parser/UserInvitation.php

src/bundle/Controller/UserInvitationController.php

src/bundle/Resources/storage/schema.yaml

src/contracts/Invitation/Exception/InvitationExist.php

src/contracts/Invitation/Exception/UserExist.php

src/lib/ConfigResolver/ConfigurableRegistrationContentTypeLoader.php

src/lib/Form/DataMapper/UserRegisterMapper.php

src/lib/Form/Type/UserInvitationType.php

src/lib/Permission/UserPermissionsLimitation.php

src/lib/Form/ChoiceList/Loader/UserGroupsChoiceLoader.php

src/bundle/Controller/UserRegisterController.php

src/contracts/Invitation/Exception/InvitationExist.php

src/contracts/Invitation/Exception/UserExist.php

src/lib/ConfigResolver/ConfigurableRegistrationContentTypeLoader.php

src/lib/Invitation/Persistence/Handler.php

src/lib/Invitation/Persistence/Mapper.php

src/lib/Permission/InvitationPolicyProvider.php

src/bundle/Controller/UserInvitationController.php

src/bundle/Controller/UserRegisterController.php

src/contracts/Invitation/Exception/InvitationAlreadyExistsException.php

src/lib/Invitation/DomainMapper.php

src/lib/Invitation/InvitationHashGenerator.php

src/lib/Invitation/InvitationService.php

src/lib/Invitation/MailSender.php

src/contracts/Invitation/Invitation.php

src/lib/Form/DataTransformer/LimitationValueTransformer.php

src/bundle/Resources/config/services/controllers.yaml

src/lib/Form/DataMapper/UserRegisterMapper.php

src/lib/Form/Type/SectionsChoiceType.php

src/lib/Invitation/InvitationHashGenerator.php

Steveb-p

Integration tests would be awesome.

Steveb-p · 2022-05-26T10:58:50Z

src/bundle/Resources/config/installer.yaml

+        autoconfigure: true
+        public: false
+        arguments:
+            - '@=service("kernel").locateResource("@IbexaUserBundle/Resources/config/storage/schema.yaml")'


This may allow developers to overwrite our schema. Shouldn't we hardcode it instead?

If someone wants to shot himself in the foot, he can. This is how we do it all across the codebase, so maybe this is just a feature ;)

src/bundle/Resources/config/services/controllers.yaml

Steveb-p · 2022-05-26T11:06:10Z

src/lib/Form/Type/Invitation/RoleChoiceType.php

+            ->setDefaults([
+                'choice_loader' => ChoiceList::lazy(
+                    $this,
+                    fn () => $this->loadFilteredRoles(),


Missing third argument ($vary). It''s not immediately visible here, but this choice list depends on current user context.

This means that this form type, used elsewhere on page, may contain incorrect list.

All changed to CallbackChoiceLoader.

src/lib/Form/Type/Invitation/UserGroupChoiceType.php

Steveb-p · 2022-05-26T11:08:10Z

src/lib/Form/Type/SiteAccessChoiceType.php

+use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
+use Symfony\Component\OptionsResolver\OptionsResolver;
+
+final class SiteAccessChoiceType extends AbstractType


Tbh it's not a User related form type. This could be extracted to core. @alongosz ?

This may or may not relate to other form types in this PR.

Core does not include a single Type and I think it should stay this way. Even more, Siteaccesses are not part of the contracts there, so I would rather leave them here as there is no good place for that and SectionsChoiceType. I will just move them to Invitation namespace to be clear about the intent.

I don't mind adding a form type, but it seems generic, that's all. Ability to select site access is not limited to ibexa/user package.

Totally agree, there is just no good place for it atm in my opinion. (aside from adminUI maybe, but we have reversed dependency here).

src/lib/Invitation/InvitationService.php

src/lib/Invitation/Persistence/Mapper.php

tests/lib/Invitation/InvitationServiceTest.php

ViniTou mentioned this pull request Apr 14, 2022

IBX-2493: Added mappers and views for new user/invite limitation ibexa/admin-ui#396

Merged

2 tasks

github-actions bot assigned dew326 Apr 14, 2022

ViniTou mentioned this pull request Apr 14, 2022

IBX-2493: Added invitation intent with role assigment handling for user creation ibexa/content-forms#29

Merged

2 tasks

ViniTou requested review from a team and Nattfarinn April 14, 2022 14:18

github-actions bot assigned mikadamczyk, Steveb-p and ViniTou Apr 22, 2022

ViniTou force-pushed the ibx-2493-user-invitations branch from a47e658 to 7204541 Compare April 27, 2022 11:50

Nattfarinn approved these changes May 10, 2022

View reviewed changes

mikadamczyk reviewed May 10, 2022

View reviewed changes

ViniTou changed the title ~~[WIP] IBX-2493: Added option to invite other users to DXP & register from invitation~~ IBX-2493: Added option to invite other users to DXP & register from invitation May 12, 2022

ViniTou requested review from mikadamczyk and adamwojs May 13, 2022 11:56

adamwojs requested changes May 16, 2022

View reviewed changes

ViniTou requested a review from adamwojs May 17, 2022 10:18

mikadamczyk reviewed May 19, 2022

View reviewed changes

ViniTou requested a review from mikadamczyk May 20, 2022 13:45

ViniTou force-pushed the ibx-2493-user-invitations branch from 342ccdd to fcdcf9d Compare May 20, 2022 13:46

adamwojs reviewed May 26, 2022

View reviewed changes

ViniTou requested a review from adamwojs May 26, 2022 09:26

adamwojs approved these changes May 26, 2022

View reviewed changes

ViniTou force-pushed the ibx-2493-user-invitations branch from ebc8470 to 1d19c34 Compare May 26, 2022 09:35

ViniTou added 7 commits May 26, 2022 11:55

IBX-2493: Added option for SA aware registered user content type

1c56574

IBX-2493: Added possibility of inviting other users to given SA

2ef438e

IBX-2493: Added limitation system for user / invite

ce6bc2b

IBX-1543: Added option to consume invitation

f56e929

IBX-2493: Added unit tests for new Limitation and Invitation validation

7e63138

IBX-2493: Fixed role filtering

6268b66

IBX-2493: Added group filtering

76089af

ViniTou added 11 commits May 26, 2022 11:55

IBX-2493: Fixed code style

bc733f7

IBX-2493: Redo UserGroup ChoiceLoader

49c50fa

IBX-2493: Fixed minor issues after code review

3b86919

IBX-2493: Refactored to use create struct

1530bd8

[CS]: Fixed codestyle

4aa3665

Used Batch iterator

e5f43a4

Fixed service name

5b96cf0

Used SA identifier instead of full object

cca3978

Extracted persistence layer

c5b22cc

Changed properties/classes visibility

5089758

Added minor fixes after review

b50a782

ViniTou force-pushed the ibx-2493-user-invitations branch from 1d19c34 to b50a782 Compare May 26, 2022 09:56

Steveb-p reviewed May 26, 2022

View reviewed changes

Moved stuff around

9057d7e

ViniTou requested a review from Steveb-p May 26, 2022 12:48

Fixed callables

f6671af

ViniTou merged commit fda7714 into main May 26, 2022

ViniTou deleted the ibx-2493-user-invitations branch May 26, 2022 14:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IBX-2493: Added option to invite other users to DXP & register from invitation #35

IBX-2493: Added option to invite other users to DXP & register from invitation #35

ViniTou commented Apr 14, 2022 •

edited

Loading

Steveb-p left a comment

Steveb-p May 26, 2022

ViniTou May 26, 2022

Steveb-p May 26, 2022

ViniTou May 26, 2022

Steveb-p May 26, 2022

ViniTou May 26, 2022 •

edited

Loading

Steveb-p May 26, 2022

ViniTou May 26, 2022

IBX-2493: Added option to invite other users to DXP & register from invitation #35

IBX-2493: Added option to invite other users to DXP & register from invitation #35

Conversation

ViniTou commented Apr 14, 2022 • edited Loading

Checklist:

Steveb-p left a comment

Choose a reason for hiding this comment

Steveb-p May 26, 2022

Choose a reason for hiding this comment

ViniTou May 26, 2022

Choose a reason for hiding this comment

Steveb-p May 26, 2022

Choose a reason for hiding this comment

ViniTou May 26, 2022

Choose a reason for hiding this comment

Steveb-p May 26, 2022

Choose a reason for hiding this comment

ViniTou May 26, 2022 • edited Loading

Choose a reason for hiding this comment

Steveb-p May 26, 2022

Choose a reason for hiding this comment

ViniTou May 26, 2022

Choose a reason for hiding this comment

ViniTou commented Apr 14, 2022 •

edited

Loading

ViniTou May 26, 2022 •

edited

Loading