Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the user registration content type configurable #12

Closed

Conversation

bdunogier
Copy link

@bdunogier bdunogier commented Dec 7, 2021

Question Answer
Tickets EZP-XXXXX
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes/no
Doc needed? yes
License GPL-2.0

Makes the user content type used for registration configurable, like the destination group.

ibexa:
  system:
    site:
      user_registration:

        # Content type identifier used for registration.
        user_type_identifier: "customer"

        # Content id of the user group where users who register are created.
        group_id:             11

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@DominikaK DominikaK added the Doc needed The changes require some documentation label Dec 8, 2021

/**
* Loads the registration content type from a configured, injected content type identifier.
*/
class ConfigurableRegistrationContentTypeLoader extends ConfigurableSudoRepositoryLoader implements RegistrationContentTypeLoader
class ConfigurableRegistrationContentTypeLoader implements RegistrationContentTypeLoader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why ConfigurableSudoRepositoryLoader was dropped here?

Copy link
Author

@bdunogier bdunogier Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was gonna say "because it doesn't need it anymore", but actually it seems that it does...

@bdunogier bdunogier closed this Jun 2, 2022
@dabrt dabrt removed the Doc needed The changes require some documentation label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants