Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to gtfs spec changes - front end UI fields only #663

Open
13 of 24 tasks
landonreed opened this issue Apr 27, 2021 · 0 comments
Open
13 of 24 tasks

Updates to gtfs spec changes - front end UI fields only #663

landonreed opened this issue Apr 27, 2021 · 0 comments
Assignees

Comments

@landonreed
Copy link
Contributor

landonreed commented Apr 27, 2021

We need to update the editor to conform to recent GTFS spec changes (full list of changes is here).

**This PR is only relating to the form fields

Agency.txt

  • show validation warning when agency_id is missing for 2 or more agencies (and daylight the error message from the server if possible)

Stops.txt

  • stop_lat/stop_long should be optional if location_type is greater than 2
  • add new location types (Station, Entrance/Exit, Generic Node, Boarding Area)
  • Stop_name should be optional if location_type is greater than 2
  • platform_code (New field)
  • needs investigation wheelchair_boarding (Type change from String to Int) was needed on the back end, is there a change on the front end needed?
  • needs investigation - zone_id
  • needs investigation - parent_station
  • needs investigation - wheelchair_boarding

Routes.txt (but edited in PatternStops.js)

  • continuous_drop_off (New field)
  • continuous_pickup (New field)
  • needs investigation - route_sort_order may need better support

Stop_times.txt

  • continuous_drop_off (New field)
  • continuous_pickup (New field)
  • needs investigation - Arrival/departure times (needs investigating)

Trips.txt

  • shape_id (update) - The continuous fields should be disabled if there is no shape.

Fair_attributes

  • needs investigation - agency_id

Shapes

  • needs investigation - major validation gaps

Feed_info.txt

  • feed_contact_email (New field)
  • feed_contact_url (New field)
  • default_lang (New field)
  • needs investigation - may need alignment

Translations

  • needs investigation - Needs update for new file

Attributions

  • needs investigation - attribution_id - Needs update for new file

Validation is handled in: https://github.com/ibi-group/datatools-ui/blob/dev/lib/editor/util/validation.js

@landonreed landonreed added the bug label Apr 27, 2021
robertgregg3 pushed a commit that referenced this issue May 6, 2021
robertgregg3 pushed a commit that referenced this issue May 11, 2021
Added defult_lang, feed_contact_email, feed_contact_url

#663
@robertgregg3 robertgregg3 changed the title Updates to agency.txt and stops.txt spec changes. Updates to gtfs spec changes - front end UI fields only Jun 1, 2021
robertgregg3 pushed a commit that referenced this issue Jun 1, 2021
….js): Update to the GTFS Spec U

Added the changes where applicable to the gtfs.yml file. Added the new types for continuous drop
off/pick up and added fields as well as basic validation in the patternStopCard file.

BREAKING CHANGE: There have been added fields that need to coincide with changes on the backend as
the api will be looking for the new fields and those fields need to be present on the Front end

#663
robertgregg3 pushed a commit that referenced this issue Jun 1, 2021
robertgregg3 pushed a commit that referenced this issue Jun 2, 2021
Changed wheelchairBoarding to a string. Added continuous fields to the map.js.

#663
@robertgregg3 robertgregg3 removed the bug label Jun 2, 2021
robertgregg3 pushed a commit that referenced this issue Jun 8, 2021
Consolidated duplicate methods into a facade type pattern

#663
robertgregg3 pushed a commit that referenced this issue Jun 28, 2021
robertgregg3 pushed a commit that referenced this issue Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants