-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(steps): implement DiscretizeKBins
transform
#57
Conversation
ibisml/steps/discretization.py
Outdated
else: | ||
warnings.warn( | ||
f"No column selected for discretization - {self.inputs!r}.", | ||
stacklevel=2, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else: | |
warnings.warn( | |
f"No column selected for discretization - {self.inputs!r}.", | |
stacklevel=2, | |
) |
I don't know that this is necessary, and I don't see any other step with it. The existing behavior is to just skip doing anything if there's no columns selected.
I'd be open to considering a warning across the board, but I think it should be done in a separate issue then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will create an separate issue for this.
DiscretizeKBins
transform
Changes addressed, and not re-reviewing right now to unblock testing
Added KBinsDiscretizer
It supports:
Examples:
Outputs:
Resolves #44