feat(duckdb): support dt.MACADDR, dt.INET as string

ibis-project · Jan 28, 2023 · c4739c7 · c4739c7
1 parent de73b37
commit c4739c7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/ibis/backends/duckdb/datatypes.py b/ibis/backends/duckdb/datatypes.py
@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import parsy as p
+import sqlalchemy as sa
 import toolz
 from duckdb_engine import Dialect as DuckDBDialect
 from sqlalchemy.dialects import postgresql
@@ -148,3 +149,8 @@ def parse_type(*args, **kwargs):
 @to_sqla_type.register(DuckDBDialect, dt.UUID)
 def sa_duckdb_uuid(_, itype):
     return postgresql.UUID
+
+
+@to_sqla_type.register(DuckDBDialect, (dt.MACADDR, dt.INET))
+def sa_duckdb_macaddr(_, itype):
+    return sa.TEXT()
diff --git a/ibis/backends/tests/test_generic.py b/ibis/backends/tests/test_generic.py
@@ -1182,6 +1182,7 @@ def test_exists(batting, awards_players, method_name):
             {
                 'bigquery': "STRING",
                 'clickhouse': "String",
+                'duckdb': 'VARCHAR',
                 'snowflake': "VARCHAR",
                 'sqlite': "text",
                 'trino': 'varchar(17)',
@@ -1190,7 +1191,7 @@ def test_exists(batting, awards_players, method_name):
             },
             marks=[
                 pytest.mark.broken(
-                    ['duckdb', 'polars'],
+                    ['polars'],
                     "<class 'ibis.expr.datatypes.core.MACADDR'>",
                     raises=KeyError,
                 ),
@@ -1202,6 +1203,7 @@ def test_exists(batting, awards_players, method_name):
             {
                 'bigquery': "STRING",
                 'clickhouse': "IPv4",
+                'duckdb': 'VARCHAR',
                 'impala': 'STRING',
                 'snowflake': "VARCHAR",
                 'sqlite': "text",
@@ -1210,7 +1212,7 @@ def test_exists(batting, awards_players, method_name):
             },
             marks=[
                 pytest.mark.broken(
-                    ['duckdb', 'polars'],
+                    ['polars'],
                     "<class 'ibis.expr.datatypes.core.INET'>",
                     raises=KeyError,
                 ),