Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add developer docs to get docker setup #1948

Merged
merged 1 commit into from
Sep 7, 2019

Conversation

toryhaavik
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #1948 into master will decrease coverage by 1.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
- Coverage   87.68%   86.01%   -1.68%     
==========================================
  Files          93       93              
  Lines       16971    16971              
  Branches     2145     2145              
==========================================
- Hits        14881    14597     -284     
- Misses       1681     1967     +286     
+ Partials      409      407       -2
Impacted Files Coverage Δ
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/bigquery/compiler.py 59.92% <0%> (-37.5%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.23% <0%> (-5.2%) ⬇️
ibis/pandas/dispatch.py 95.45% <0%> (-4.55%) ⬇️
ibis/pandas/client.py 85.54% <0%> (-3.47%) ⬇️
ibis/bigquery/api.py 63.33% <0%> (-3.34%) ⬇️
ibis/expr/schema.py 90.1% <0%> (-1.1%) ⬇️
ibis/sql/compiler.py 94.26% <0%> (-0.39%) ⬇️
ibis/expr/api.py 92.33% <0%> (-0.37%) ⬇️
... and 1 more

@toryhaavik
Copy link
Contributor Author

Why would code coverage change for a simple change to the documentation? Any ideas @cpcloud ?

@xmnlab
Copy link
Contributor

xmnlab commented Sep 6, 2019

some days ago codecov appears in a discussion on https://gitter.im/ibis-dev/Lobby

my impression is that codecov need some "calibration"

@toryhaavik toryhaavik added the docs Documentation related issues or PRs label Sep 6, 2019
Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @toryhaavik for working on that.

@xmnlab xmnlab merged commit 0f1a776 into ibis-project:master Sep 7, 2019
costrouc pushed a commit to costrouc/ibis that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants