Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG/CI: Fix doc build ci, fix mysql container over HDD and fix doc section inside Makefile #2030

Merged
merged 8 commits into from Nov 16, 2019
Merged

BUG/CI: Fix doc build ci, fix mysql container over HDD and fix doc section inside Makefile #2030

merged 8 commits into from Nov 16, 2019

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Nov 16, 2019 •
edited

In this PR:

@xmnlab xmnlab changed the title CI: Fix doc build ci and change mysql default port WIP CI: Fix doc build ci and change mysql default port Nov 16, 2019
@scottcode
Copy link
Contributor

@xmnlab Thanks for the work on all these different issues! This addresses a lot of very different and independent issues. Should we consider splitting this up into separate pull requests divided into more cohesive chunks. For example:

  1. Doc fixes (Makefile and semantic_version pin)
  2. MySQL-related fixes
  3. updated omniscidb image

@xmnlab
Copy link
Contributor Author

xmnlab commented Nov 16, 2019

@scottcode it sounds good.
but I think that skip mysql tzinfo should be here .. because without that I cannot test it locally.

@xmnlab xmnlab mentioned this pull request Nov 16, 2019
Closed
@scottcode
Copy link
Contributor

@scottcode it sounds good.
but I think that skip mysql tzinfo should be here .. because without that I cannot test it locally.

Makes sense, @xmnlab. Thanks for splitting out the things that doc build fix doesn't depend on.

@scottcode scottcode self-requested a review November 16, 2019 20:16
scottcode
scottcode approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@scottcode scottcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with the narrowed scope, this all looks good to me

@scottcode
Copy link
Contributor

Since I don't write access to the project, my approval doesn't enable the merge. Someone else with write privs will need to approve and merge.

@jreback jreback added the ci Continuous Integration issues or PRs label Nov 16, 2019
@jreback jreback added this to the Next Feature Release milestone Nov 16, 2019
jreback
jreback reviewed Nov 16, 2019
View reviewed changes
ci/requirements-docs.yml
@@ -10,3 +10,5 @@ pyarrow>=0.12
sphinx=2.0.1
sphinx-releases
sphinx_rtd_theme
# https://github.com/ibis-project/ibis/issues/2027
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is pulling this in now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would create an issue to remove this pin when the underlying issue is resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sphinx-releases has an issue that a change in semantic_version caused. You're right, we should have another issue to remove the pin when it gets fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created an issue to unpin semantic_version once the issue is fixed (#2033)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @scottcode ! I adding a release note now here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmnlab ok, lgtm. ping when ready.

@scottcode scottcode mentioned this pull request Nov 16, 2019
Closed
jreback
jreback reviewed Nov 16, 2019
View reviewed changes
docs/source/release.rst Outdated
@@ -8,6 +8,7 @@ Release Notes
notes for pre-1.0 versions of ibis can be found at :doc:`/release-pre-1.0`

* :release:`1.2.1 <pending>`
* :bug:`2030` Fix LinuxBuildDocs issue related to semantic_version, fix doc section inside Makefile and skip mysql tzinfo on CI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a user point of view this is not very useful. what IS useful and worth mentioning, is that we now have a pin in the docs build (its not really user, but developer user here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. I updated the release note. let me know if it needs any other change.

@xmnlab xmnlab changed the title WIP CI: Fix doc build ci and change mysql default port CI: Fix doc build ci and change mysql default port Nov 16, 2019
@xmnlab xmnlab changed the title CI: Fix doc build ci and change mysql default port BUG/CI: Fix doc build ci and change mysql default port Nov 16, 2019
jreback
jreback approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @xmnlab ping on green.

@xmnlab xmnlab changed the title BUG/CI: Fix doc build ci and change mysql default port BUG/CI: Fix doc build ci, fix mysql container over HDD and fix doc section inside Makefile Nov 16, 2019
@xmnlab xmnlab mentioned this pull request Nov 16, 2019
Merged
@xmnlab
Copy link
Contributor Author

xmnlab commented Nov 16, 2019

green :)

@jreback jreback merged commit a6bdbdd into ibis-project:master Nov 16, 2019
@jreback
Copy link
Contributor

jreback commented Nov 16, 2019

thanks @xmnlab

@jreback
Copy link
Contributor

jreback commented Nov 16, 2019

rebase the other PRs and we'll get em in

@xmnlab xmnlab deleted the fix-docstring-ci branch November 16, 2019 23:11
@xmnlab xmnlab mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottcode scottcode scottcode approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
ci Continuous Integration issues or PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI/BUG: LinuxBuildDocs failing
3 participants
@xmnlab @scottcode @jreback