Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: [Omnisci] Drop table only if it exists #2050

Merged
merged 2 commits into from Jan 21, 2020
Merged

CI: [Omnisci] Drop table only if it exists #2050

merged 2 commits into from Jan 21, 2020

Conversation

semelianova
Copy link
Contributor

Omnisci raises an exception if you try to drop a non-existing table

@xmnlab
Copy link
Contributor

xmnlab commented Jan 20, 2020

looks good @semelianova !
could you add a release note?

https://github.com/ibis-project/ibis/blob/master/docs/source/release.rst

you can add that after :release: 1.2.1 <pending> line

thanks for working on that.

@xmnlab xmnlab self-assigned this Jan 20, 2020
@xmnlab xmnlab added ci Continuous Integration issues or PRs omnisci labels Jan 20, 2020
@jreback jreback added this to the Next Feature Release milestone Jan 20, 2020
@xmnlab xmnlab self-requested a review January 21, 2020 17:06
xmnlab
xmnlab approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @semelianova

@xmnlab xmnlab merged commit 52c5aa9 into ibis-project:master Jan 21, 2020
@semelianova semelianova deleted the ci_drop_table branch January 21, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab xmnlab approved these changes

Assignees

@xmnlab xmnlab

Labels
ci Continuous Integration issues or PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semelianova @xmnlab @jreback