Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CondaBuild CI job #2195

Merged
merged 2 commits into from
May 7, 2020
Merged

Fix CondaBuild CI job #2195

merged 2 commits into from
May 7, 2020

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Apr 23, 2020

Currently condabuild ci job is failing because:

  • the current conda recipe doesn't work for python 3.8, because pymapd depends on pyarrow <= 0.13 and it has dependency conflict with another packages. also the current pyspark will not work well for python 3.8 (waiting pyspark v3)
  • as conda recipe uses noarch:python, and currently the conda build uses the python 3.8 to build, the build will have a very complex dependency tree to resolve

in this PR:

  • I changed the repo and the branch used to get the conda recipe to check if the new recipe will work
  • I added the python flag to feedstock.py test to specify the python version to conda-build

notes:

  • as can be observed, it worked. the time spent is not the desired yet (43m) but as the time limit is 1h, probably it is enough for now.
  • would be good to improve more this, maybe in a follow up PR. something that could help to improve this would be: 1) use mamba for building and 2) change the pinning of some packages (in the conda recipe).

@jreback
Copy link
Contributor

jreback commented May 7, 2020

ok I merged the feedstock PR. do we need this one any more?

@xmnlab
Copy link
Contributor Author

xmnlab commented May 7, 2020

the time necessary for building the package on conda-forge using the current recipe:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=157972&view=results

after some pinnings:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=158182&view=results

the job for python 3.7 (on conda-forge feedstock) reduced from 1h22m to 0h07m

WIP PR: conda-forge/ibis-framework-feedstock#43

@jreback
Copy link
Contributor

jreback commented May 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jreback jreback added this to the Next Bugfix Release milestone May 7, 2020
@jreback jreback added the ci Continuous Integration issues or PRs label May 7, 2020
@jreback jreback mentioned this pull request May 7, 2020
@jreback jreback merged commit 5cdf85f into ibis-project:master May 7, 2020
@jreback
Copy link
Contributor

jreback commented May 7, 2020

thanks @xmnlab and @datapythonista

looks like we are back to green!

now to merge anything omnisci or spark we have to add back builds.

@xmnlab xmnlab deleted the fix-ci-build branch May 7, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants