Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(polars): allow ibis.polars.connect() to function without any passed arguments #5275

Merged
merged 1 commit into from Jan 20, 2023

Conversation

ksuarez1423
Copy link
Contributor

Adds functionality to Polars backend so ibis.polars.connect() yields a Polars connection with nothing in it.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023

Test Results

       43 files         43 suites   1h 48m 20s ⏱️
13 409 tests 10 134 ✔️   3 272 💤 3
46 429 runs  34 650 ✔️ 11 776 💤 3

For more details on these failures, see this check.

Results for commit ece8b36.

♻️ This comment has been updated with latest results.

@ksuarez1423 ksuarez1423 changed the title feat(polars): Allow ibis.polars.connect() to function without any passed arguments feat(polars): allow ibis.polars.connect() to function without any passed arguments Jan 20, 2023
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix, otherwise this lgtm.

ibis/backends/polars/__init__.py Outdated Show resolved Hide resolved
@jcrist jcrist merged commit d653a07 into ibis-project:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants