Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support connect() with no arguments for dask and pandas #5315

Merged
merged 2 commits into from
Jan 24, 2023
Merged

feat: support connect() with no arguments for dask and pandas #5315

merged 2 commits into from
Jan 24, 2023

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Jan 24, 2023

A minor UX improvement, following up from #5275.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023 •
edited
Loading

Test Results

       43 files         43 suites   1h 51m 50s ⏱️
13 808 tests 10 325 ✔️   3 483 💤 0 ❌
47 770 runs  35 223 ✔️ 12 547 💤 0 ❌

Results for commit 9cb2725.

♻️ This comment has been updated with latest results.

@cpcloud cpcloud added this to the 4.1 milestone Jan 24, 2023
@cpcloud cpcloud added pandas The pandas backend dask The Dask backend labels Jan 24, 2023
cpcloud
cpcloud approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpcloud cpcloud merged commit 67eed42 into ibis-project:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
dask The Dask backend pandas The pandas backend
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jcrist @cpcloud