Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duckdb): ensure that temp_directory exists #5380

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 30, 2023

This PR fixes an issue where a non-existent directory can be used for out of core processing. The solution is to create the directory and its parents.

@cpcloud cpcloud added this to the 5.0 milestone Jan 30, 2023
@cpcloud cpcloud added bug Incorrect behavior inside of ibis duckdb The DuckDB backend labels Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

Test Results

       43 files         43 suites   1h 47m 2s ⏱️
13 920 tests 10 405 ✔️   3 515 💤 0
48 137 runs  35 469 ✔️ 12 668 💤 0

Results for commit ab4b1e3.

♻️ This comment has been updated with latest results.

@kszucs kszucs merged commit 00ba6cb into ibis-project:master Jan 31, 2023
@cpcloud cpcloud deleted the fix-temp-directory-creation branch March 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis duckdb The DuckDB backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants