Frank!Doc: Apply Reintroduce annotation #3529
Conversation
|
Draft because FRANKDOC.md remains to be updated. |
| @@ -34,27 +35,32 @@ | |||
| @Category("Basic") | |||
| public class SenderPipe extends MessageSendingPipe { | |||
|
|
|||
| @Override // to obtain proper order in FrankDoc and XSD | |||
There was a problem hiding this comment.
Het is wel handig ergens in deze klasse een dergelijke tekst te zetten waarom deze methodes hier op deze manier in staan.
There was a problem hiding this comment.
In my opinion, the @Reintroduce annotation should make this clear already. I have updated the JavaDoc comment of the Reintroduce class. If you hover over the @Reintroduce annotation, you see the explanation.
| * child is repeated already without the need to add this annotation. | ||
| * | ||
| * Although it is technically possible to apply this annotation on attributes, doing so does | ||
| * not make sense because XML schema does not enforce the order in which attributes appear |
There was a problem hiding this comment.
Maar het heeft toch wel invloed op de volgorde waarin de attriubuten aan de FrankDeveloper gepresenteerd worden? Dat is relevant, c.q. maakt sense.
There was a problem hiding this comment.
Dit stukje commentaar is nu weg.
| * This annotation has no impact on the Frank!Doc webapp. WeAreFrank! decided so because | ||
| * repeated config children would look confusing. If an overriding config child setter |
There was a problem hiding this comment.
ConfigChilderen moeten niet gerepeat worden, maar wel in de juiste volgorde staan. Daarom moet het ook invloed hebben op de Frank!Doc webapp. Zie mijn commentaar in de 'conversation' van dit PR.
There was a problem hiding this comment.
Dit stukje commentaar is nu weg.
No description provided.