Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

As a developer, I can use service discovery with the local Fabric #776

Closed
sstone1 opened this issue Mar 27, 2019 · 1 comment
Closed

As a developer, I can use service discovery with the local Fabric #776

sstone1 opened this issue Mar 27, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sstone1
Copy link
Contributor

sstone1 commented Mar 27, 2019

The local Fabric currently does not enable you to use service discovery. This is because the peer does not currently have an external endpoint address set, and the orderer address in the channel configuration block does not work outside of the Docker network.

This is okay, but it means that any sample applications run inside VSCode cannot be configured to use service discovery, and this means that developers must write different code to toggle service discovery on or off depending on if they are using the local Fabric or trying to interact with the SaaS.

Our desire is to see all applications running with service discovery, so we should really be demonstrating this out of the box from the start with the local Fabric working with the samples, and allow you to use those exactly same samples with the SaaS.

@sstone1 sstone1 added the enhancement New feature or request label Mar 27, 2019
@sstone1 sstone1 self-assigned this Mar 27, 2019
@cazfletch cazfletch added this to the Sprint 4 milestone Mar 28, 2019
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Mar 29, 2019
…n#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Mar 29, 2019
…n#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Mar 29, 2019
…n#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
cazfletch pushed a commit that referenced this issue Apr 1, 2019
Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 1, 2019
…(contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 1, 2019
…(contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 1, 2019
…(contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
cazfletch pushed a commit that referenced this issue Apr 1, 2019
…(contributes to #776) (#786)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 1, 2019
…ibutes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 1, 2019
sstone1 pushed a commit that referenced this issue Apr 1, 2019
UserInputUtil.getDirPath should be sync (contributes to #776)
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 1, 2019
sstone1 pushed a commit that referenced this issue Apr 1, 2019
Sanitize the connection functions around node names (contributes to #776)
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 1, 2019
…utes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 1, 2019
…utes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
cazfletch pushed a commit that referenced this issue Apr 1, 2019
…utes to #776) (#789)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 1, 2019
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 2, 2019
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 2, 2019
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 2, 2019
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 2, 2019
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 2, 2019
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 2, 2019
…untime (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 2, 2019
…untime (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 2, 2019
…untime (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 23, 2019
… changes (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 23, 2019
…ges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 23, 2019
…anges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 23, 2019
…(contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 23, 2019
…nges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 23, 2019
…est changes (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 23, 2019
… changes (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 23, 2019
…ges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 23, 2019
…anges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…(contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…nges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…est changes (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
… changes (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…ges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…anges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…(contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…nges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…est changes (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
… changes (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…ges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…anges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…(contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…nges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…est changes (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
… changes (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…ges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
sstone1 pushed a commit to sstone1/blockchain-vscode-extension that referenced this issue Apr 24, 2019
…anges (contributes to IBM-Blockchain#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
@heatherlp
Copy link
Contributor

@sstone1 is this done?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants