Skip to content

Commit

Permalink
Avoid spurious accessibility warning by removing List's tabindex.
Browse files Browse the repository at this point in the history
  • Loading branch information
wkeese committed May 14, 2019
1 parent 54a18fc commit 625dab3
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions Combobox.js
Original file line number Diff line number Diff line change
Expand Up @@ -997,6 +997,12 @@ define([
}
this.dropDown.focus();
}

// Avoid spurious error from accessibility DOM scanning tool. I don't like reaching into the
// List internals but there's no way to remove the tabindex attribute by setting the
// List#tabIndex property (or for that matter, by setting HTMLElement#tabIndex property for any
// HTMLElement).
this.dropDown.containerNode.removeAttribute("tabindex");
}.bind(this));
};
}),
Expand Down

0 comments on commit 625dab3

Please sign in to comment.