Fix/component imports railtie #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasemcdo
force-pushed
the
fix/component-imports-railtie
branch
from
771e7b4
to
4937693
Compare
This reverts commit 3e2b4af.
* move components to app * Move component loading to engine * add view_component/engine require to engine * Revert "add view_component/engine require to engine" This reverts commit 797d977. * Revert "Merge branch 'fix/replicate-polaris' of https://github.com/ibm-skills-network/sn_filterable into fix/replicate-polaris" This reverts commit 3213ee4, reversing changes made to 797d977. * Revert "Revert "add view_component/engine require to engine"" This reverts commit 2e3e9b7. * add comoponents/sn_filterable sub folder * fix namespace mismatches * remove BaseComponents namespace from FilterButtonComponent * precompile js * Revert "precompile js" This reverts commit 90020e0. * add js to autoload paths * Revert "add js to autoload paths" This reverts commit 06d81e7. * add load_js * load_js -> self.load_js * Update README.md * Add implementation steps * rubocop adjustments * Add testing details to readme * adjust readme code format * update readme gemfile install instructions * Update README.md * add demo gif * change bundle install format * grammatical readme adjustments * Add search bar usage instructions * update table rendering in readme * Add sort too readme usage * Update README.md * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.