feat: add extra_params option #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,14 +24,16 @@ class MainComponent < ViewComponent::Base | |||
| # @param [String, nil] search_filter_name Optional, enable's and set's the search filter, specified by the filter's parameter name | |||
| # @param [Boolean] show_sidebar If true, will show the sidebar with the filters. | |||
| # @param [Boolean] update_url_on_submit If true, will update the URL in the user's browser on form submission. | |||
| def initialize(frame_id:, filtered:, filters:, url: nil, search_filter_name: nil, show_sidebar: true, update_url_on_submit: true) | |||
| # @param [Hash] extra_params Optional, allows for custom form values to be supplied. Useful if you need to retain non-filterable query params | |||
There was a problem hiding this comment.
I wasn't sure on a great name for this variable, let me know if you have any suggestions
There was a problem hiding this comment.
i think the name is fine, I guess we could maybe do hidden_params to convey that it will generate hidden inputs.
danielrudn
approved these changes
Feb 1, 2024
| @@ -24,14 +24,16 @@ class MainComponent < ViewComponent::Base | |||
| # @param [String, nil] search_filter_name Optional, enable's and set's the search filter, specified by the filter's parameter name | |||
| # @param [Boolean] show_sidebar If true, will show the sidebar with the filters. | |||
| # @param [Boolean] update_url_on_submit If true, will update the URL in the user's browser on form submission. | |||
| def initialize(frame_id:, filtered:, filters:, url: nil, search_filter_name: nil, show_sidebar: true, update_url_on_submit: true) | |||
| # @param [Hash] extra_params Optional, allows for custom form values to be supplied. Useful if you need to retain non-filterable query params | |||
There was a problem hiding this comment.
i think the name is fine, I guess we could maybe do hidden_params to convey that it will generate hidden inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
add a new named parameter to SnFilterable::MainComponent.
extra_params: { tab: "my_organizations" }will add a hidden form input with name tab and value my_organizations