feat: mysql support #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking change: The gem no longer depends directly on the `pg_search` gem. This means models using `pg_search_scope` must be updated to explicitly `include PgSearch::Model`.
danielrudn
commented
Apr 25, 2024
Comment on lines
-196
to
-204
| it "can search ignoring diacritics" do | ||
| all_items = BasicFilterableTestModel.where(nil) | ||
| expected_items = [all_items.first.name] | ||
|
|
||
| filtered = BasicFilterableTestModel.filter(params: ActionController::Parameters.new({ filter: { search: target_user.name.split(//).join("").tr("aeiouylszcn", "àèîôûÿłšżçñ") } })) | ||
|
|
||
| expect(filtered.items.map(&:name)).to eq(expected_items) | ||
| end | ||
|
|
There was a problem hiding this comment.
this test had a dependency on pg_search and seems pretty specific to pg_search so I removed it
danielrudn
commented
Apr 25, 2024
Comment on lines
+520
to
+536
| if ActiveRecord::Base.connection_db_config.adapter == "mysql2" | ||
| "LEFT OUTER JOIN `#{first_model_table}` ON `#{first_model_table}`.id = `#{base_model_table}`.`#{polymorphic_association_id}` AND `#{base_model_table}`.`#{polymorphic_association_type}` = '#{first_model_name}'" | ||
| else | ||
| "LEFT OUTER JOIN \"#{first_model_table}\" ON \"#{first_model_table}\".id = \"#{base_model_table}\".\"#{polymorphic_association_id}\" AND \"#{base_model_table}\".\"#{polymorphic_association_type}\" = '#{first_model_name}'" | ||
| end | ||
| end | ||
| end | ||
|
|
||
| describe ".coalesce" do | ||
| it "creates a valid function" do | ||
| actual_output = described_class.coalesce([DummyModel], "some_column") | ||
|
|
||
| expect(actual_output).to eq("coalesce(\"dummy_models\".\"some_column\")") | ||
| if ActiveRecord::Base.connection_db_config.adapter == "mysql2" | ||
| expect(actual_output).to eq("coalesce(`dummy_models`.`some_column`)") | ||
| else | ||
| expect(actual_output).to eq("coalesce(\"dummy_models\".\"some_column\")") | ||
| end |
There was a problem hiding this comment.
there were only two tests that were expecting postgres syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mysql with the
mysql2adapter.It is a major version bump
2.0.0 -> 3.0.0because thepgandpg_searchdependencies are now development dependencies. See theBreaking Changesection for more details.The rspec test suite now runs on both Postgres and MySQL databases during the test github action.
Breaking Change
The gem no longer depends directly on the
pg_searchgem. This meansmodels using
pg_search_scopemust be updated to explicitlyinclude PgSearch::Model.When upgrading from 2.x to 3.x, follow these steps:
pgandpg_searchgems are present ifpg_search_scopeis usedinclude SnFilterable::Filterablethat also usespg_search_scopeinclude PgSearch::Modelfor results from step 2