retry is not kicking in with npm 6.x

[bartvde]

Looks like the error message is not matched, is this a known issue?

bartvde@bartvde-XPS-13-9360:~/planet/git/audit-ci$ git diff
diff --git a/lib/audit.js b/lib/audit.js
index 501ea59..62c042e 100644
--- a/lib/audit.js
+++ b/lib/audit.js
@@ -7,9 +7,9 @@ function audit(pm, config, reporter) {
   const RETRY_ERROR_MSG = {
     npm: `${
       config.registry
-        ? `npm ERR! audit Your configured registry (${config.registry}) `
+        ? `code ENOAUDIT: Your configured registry (${config.registry}) `
         : ''
-    }does not support audit requests`,
+    }may not support audit requests, or the audit endpoint may be temporarily unavailable.`,
     yarn: '503 Service Unavailable',
   };

[bartvde]

@djomaa since you did the original PR at #82, do you have any idea why the error is not getting matched with npm 6.13.7?

[quinnturner]

A bit of digging confirms that both are error messages:

This is certainly an issue. I am not a fan of processing the error message since it's very brittle, but a quick fix would be an if+elseif on the msg. Preferably, we could process the statusCode.

From the NPM audit src:

  if (err.statusCode >= 400) {
    let msg
    if (err.statusCode === 401) {
      msg = `Either your login credentials are invalid or your registry (${opts.registry}) does not support audit.`
    } else if (err.statusCode === 404) {
      msg = `Your configured registry (${opts.registry}) does not support audit requests.`
    } else {
      msg = `Your configured registry (${opts.registry}) may not support audit requests, or the audit endpoint may be temporarily unavailable.`
    }
    if (err.body.length) {
      msg += '\nThe server said: ' + err.body
    }
    const ne = new Error(msg)
    ne.code = 'ENOAUDIT'
    ne.wrapped = err
    throw ne
  }
  throw err

Note that his has been an issue for npm >= v6.10.2: nodejs/node@d7d321b

EDIT: Didn't mean to close!

[quinnturner]

A quicker fix is simply to shorten the partial error message matching to not support audit. This way, all error messages are captures. Eventually, this should be cleaned up into proper error code handling, but this is an improvement over the current solution.

[bartvde]

thanks @quinnturner !