-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate retry mechanism #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the retry attempt should be configurable. Perhaps the following specification? Arg: none Placing this ^ after Config file spec: Also, we should consider documenting this behaviour in the README.
|
@quinnturner all is ready. I also changed audit start flow for the availability of the mechanism in tests |
I personally use this for development purposes and is a nice-to-have
Created djomaa#1 for some minor fixes along with a It would be a nice-to-have having a test that fails at first due to a 503 then passes. However, it's okay if that is added later. |
Retry mechanism test fixes
Fixes #75
Now if audit fails due to npm registry, it's repeated up to 5 times.
Probably, it would be cool to create parameters for retry delay and retry max attempts.