Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Make app name configurable #5

Closed
MLnick opened this issue Jan 16, 2019 · 3 comments
Closed

Make app name configurable #5

MLnick opened this issue Jan 16, 2019 · 3 comments
Assignees
@splovyt

Comments

@MLnick
Copy link

MLnick commented Jan 16, 2019

This line: https://github.com/IBM/MAX-Framework/blob/master/maxfw/core/app.py#L13

means that the app name when serving in Flask looks like:

 * Serving Flask app "maxfw.core.app" (lazy loading)
 * Environment: production
...

Not too major, but would be nice to make the app name a configurable property.
@bdwyer2 bdwyer2 mentioned this issue Jan 16, 2019
Merged
@splovyt
Copy link
Contributor

splovyt commented Jan 16, 2019

Would you want to set it equal to the API_TITLE variable or as a new variable APP_NAME?
Since we are aiming for user-friendly API titles, I personally think setting it to API_TITLE is preferable. Let me know what you think!

@splovyt splovyt mentioned this issue Jan 17, 2019
Merged
@MLnick
Copy link
Author

MLnick commented Jan 17, 2019

I think API_TITLE makes sense yes

@splovyt
Copy link
Contributor

splovyt commented Jan 28, 2019

This was addressed in PR #6. Thanks for the suggestion!

@splovyt splovyt closed this as completed Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@splovyt splovyt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MLnick @splovyt