Improvements and bugfixes in common bash functions #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2019 11:44
- When an user specifies, in the AI-specific <ROLE>_DATA_DIR attribute the value "none" (indicating that a given application will use the volume without a filesystem on it), the function mount_filesystem_on_volume can now be called without resulting in error - The function check_container now correctly detects the number of CPUs and amount of memory available, in KB. - Make sure every other function (e.g., haproxy_setup) uses the function check_container
|
I'll test this one in a little bit with the wrk2 workload to make sure everything's still running on my end, one moment......... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the value "none" (indicating that a given application will use the volume without a filesystem on it), the function mount_filesystem_on_volume can now be called without resulting in error