fix MetricStoreMgdConnException issue #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We faced an issue within cb in which when the code path was touching this user-defined exception "MetricStoreMgdConnException" python3 complained with following msg: "TypeError: catching classes that do not inherit from BaseException is not allowed." Due to this, the client API object was getting hung and the client API kept waiting to receive something from the socket. This fixes the issue by using local version of MetricStoreMgdConnException class and because of that we no longer see that TypeError msg.
|
This one looks good, and fixes a bug I was seeing too. Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We faced an issue within cb in which when the code path
was touching this user-defined exception "MetricStoreMgdConnException"
python3 complained with following msg:
"TypeError: catching classes that do not inherit from BaseException
is not allowed."
Due to this, the client API object was getting hung and the client API kept
waiting to receive something from the socket. This fixes the issue
by using local version of MetricStoreMgdConnException class and
because of that we no longer see that TypeError msg.