Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cause a system dump on failure of UncaughtExceptionsTest #655

Merged
merged 1 commit into from
May 11, 2023

Conversation

pshipton
Copy link
Member

Seems I caught the exception on the wrong line. Include all the cases.

Related to #647 and eclipse-openj9/openj9#11930 (comment)

Seems I caught the exception on the wrong line. Include all the cases.

Related to ibmruntimes#647
and eclipse-openj9/openj9#11930 (comment)

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton pshipton requested a review from keithc-ca May 11, 2023 18:12
Copy link
Member

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intent to apply this change to newer versions as well, or just to Java 11 to help diagnose the underlying problem?

@keithc-ca keithc-ca merged commit ee54452 into ibmruntimes:openj9 May 11, 2023
@pshipton
Copy link
Member Author

Just jdk11. I'm only seeing the failure on jdk11. we excluded the test on jdk17 and I expect that's carried forward. If we can fix the problem we can unexclude the test in all versions.

pshipton added a commit to pshipton/openj9-openjdk-jdk11 that referenced this pull request May 31, 2023
Obsoletes ibmruntimes#655

Related to
eclipse-openj9/openj9#11930 (comment)

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton added a commit to pshipton/openj9-openjdk-jdk11 that referenced this pull request Jun 1, 2023
Obsoletes ibmruntimes#655

Related to
eclipse-openj9/openj9#11930 (comment)

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants