Cloneable test in HmacCore seems questionable #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilburZjh
force-pushed
the
enableMDCloneable
branch
from
b0e5257
to
16c4f76
Compare
|
Hi @keithc-ca , please help to review. |
keithc-ca
requested changes
Jun 8, 2023
test/jdk/com/sun/crypto/provider/Mac/DigestCloneabilityTest.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/com/sun/crypto/provider/HmacCore.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/sun/security/provider/DigestBase.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinhang Zhang <Jinhang.Zhang@ibm.com>
WilburZjh
force-pushed
the
enableMDCloneable
branch
from
16c4f76
to
34a3775
Compare
|
In the future, please ensure commit messages contain enough information that someone reviewing it years down the road will understand the change and why it was made. |
|
Jenkins test sanity osx jdk11 |
keithc-ca
approved these changes
Jun 8, 2023
|
Does this update need to go into the the 0.40 release? |
I think it should (assuming it doesn't cause any issues in the main branch). |
|
Created #668 for 0.40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport PR from JDK17 PR ibmruntimes/openj9-openjdk-jdk17@b88cc72 to JDK11.