Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Update Harfbuzz to 7.0.1 #683

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

pshipton
Copy link
Member

@keithc-ca
Copy link
Member

I think this is missing 3319f31 (#632).

@pshipton
Copy link
Member Author

3319f31 is already in the v0.40.0-release branch.

@pshipton
Copy link
Member Author

Keith said, you can see the changes are missing when comparing against the 0.38 release branch. I cherry picked the change and added it.

@keithc-ca
Copy link
Member

3319f31 is already in the v0.40.0-release branch.

You're right: The v0.40.0-release branch is currently at 20e0e53 and merge-base agrees:

$ git merge-base --is-ancestor 3319f3173433e376e3d799b0dbb7ba8e0d70398d 20e0e5315796df31dbe6c69e5681b0a4d240ed2c && echo yes
yes

I think that change was lost via a merge that accepted 1a36154 verbatim.

@keithc-ca
Copy link
Member

Jenkins compile aix jdk11 depends eclipse-openj9/openj9#v0.40.0-release eclipse-openj9/openj9-omr#v0.40.0-release

@pshipton
Copy link
Member Author

jdk_imageio testing at https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/2584/
There is one failure but seems unrelated.

@keithc-ca keithc-ca merged commit b427b85 into ibmruntimes:v0.40.0-release Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants