Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CacheClass to ClassByNameCache to avoid OpenJDK conflict #99

Merged
merged 1 commit into from
May 4, 2022

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented May 4, 2022

@pshipton pshipton force-pushed the classcache branch 2 times, most recently from 3b6d99b to 08e4792 Compare May 4, 2022 19:40
@pshipton
Copy link
Member Author

pshipton commented May 4, 2022

jenkins compile amac jdk17

@pshipton pshipton requested a review from keithc-ca May 4, 2022 19:56
@pshipton
Copy link
Member Author

pshipton commented May 4, 2022

The OpenJDK change was backported to 17. I'll make this change for 18 as well after review.

@pshipton pshipton changed the title Rename CacheClass to CacheNameCache to avoid OpenJDK conflict Rename CacheClass to CacheByNameCache to avoid OpenJDK conflict May 4, 2022
@pshipton
Copy link
Member Author

pshipton commented May 4, 2022

jenkins compile amac jdk17

@keithc-ca
Copy link
Member

Note that we'll also need this for Java 11 after ibmruntimes/openj9-openjdk-jdk11#514 is merged.

pshipton added a commit to pshipton/openj9-openjdk-jdk that referenced this pull request May 4, 2022
See ibmruntimes#388
ibmruntimes/openj9-openjdk-jdk17#99

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member Author

pshipton commented May 4, 2022

PR build https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJDK17/44/

pshipton added a commit to pshipton/openj9-openjdk-jdk18 that referenced this pull request May 4, 2022
pshipton added a commit to pshipton/openj9-openjdk-jdk18 that referenced this pull request May 4, 2022
@pshipton pshipton requested a review from keithc-ca May 4, 2022 21:13
pshipton added a commit to pshipton/openj9-openjdk-jdk11 that referenced this pull request May 4, 2022
pshipton added a commit to pshipton/openj9-openjdk-jdk11 that referenced this pull request May 4, 2022
@keithc-ca keithc-ca changed the title Rename CacheClass to CacheByNameCache to avoid OpenJDK conflict Rename CacheClass to ClassByNameCache to avoid OpenJDK conflict May 4, 2022
pshipton added a commit to pshipton/openj9-openjdk-jdk that referenced this pull request May 4, 2022
See ibmruntimes#388
ibmruntimes/openj9-openjdk-jdk17#99

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@keithc-ca keithc-ca merged commit d7231b1 into ibmruntimes:openj9 May 4, 2022
pshipton added a commit to pshipton/openj9-openjdk-jdk8 that referenced this pull request May 19, 2022
pshipton added a commit to pshipton/openj9-openjdk-jdk8 that referenced this pull request May 19, 2022
pshipton added a commit to pshipton/openj9-openjdk-jdk8 that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants