Rename CacheClass to ClassByNameCache to avoid OpenJDK conflict #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins compile xmac jdk8 |
keithc-ca
requested changes
May 19, 2022
closed/adds/jdk/src/share/classes/java/io/ClassByNameCache.java
Outdated
Show resolved
Hide resolved
See ibmruntimes/openj9-openjdk-jdk17#99 ibmruntimes/openj9-openjdk-jdk#388 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Fixed the 2 review comments. |
keithc-ca
approved these changes
May 19, 2022
|
There's no need to repeat a build for those cosmetic changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ibmruntimes/openj9-openjdk-jdk17#99
ibmruntimes/openj9-openjdk-jdk#388
Signed-off-by: Peter Shipton Peter_Shipton@ca.ibm.com