This repository has been archived by the owner on Oct 22, 2020. It is now read-only.
Rework generation of openj9_version_info.h #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes ibmruntimes#87 Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
jenkins test sanity |
jdekonin
reviewed
Sep 29, 2017
| $(foreach var,$(OPENJ9_VERSION_VARS),-e 's:@${var}@:$(value $(var)):g') | ||
|
|
||
| $(OUTPUT_ROOT)/vm/util/openj9_version_info.h : $(SRC_ROOT)/closed/openj9_version_info.h.in | ||
| @$(MKDIR) -p $(@D) |
There was a problem hiding this comment.
The directory should already be present from a successful stage-j9 target execution so the mkdir shouldn't be required here. This will likely be needed once we determine where generated artifacts from openj9 are going to be 'kept'.
There was a problem hiding this comment.
For everyone's benefit: you can assume the actions of another target have occurred only if that target is a (possibly indirect) prerequisite. Make could legally build prerequisites in any order it sees fit (and will likely do so when allowed to do things in parallel) it is only bound by dependencies.
jdekonin
approved these changes
Sep 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the second approach described in #11 in that make generates or updates openj9_version_info.h as necessary.
Fixes #11
Fixes eclipse-openj9/openj9#87