Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added bash_tests #141

Closed
wants to merge 3 commits into from
Closed

added bash_tests #141

wants to merge 3 commits into from

Conversation

mkhuthir
Copy link

@mkhuthir mkhuthir commented May 4, 2019 •
edited

(#140 ) Adding bash scripts to test Watson AI services without the use of TJBOT Node.JS Lib.

Signed-off-by: Muthanna A. Alwahash mkhuthir@gmail.com

jweisz
jweisz requested changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@jweisz jweisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great contribution, thank you! I just have a few comments / questions, please take a look. Also, should this go inside bash_tests/, or should we put it in tests/ or maybe tests/watson?

bash_tests/README.md Outdated Show resolved Hide resolved
bash_tests/hw_bluetooth_speaker.sh Outdated Show resolved Hide resolved
bash_tests/language_translator_1.sh Outdated Show resolved Hide resolved
bash_tests/language_translator_1.sh Outdated Show resolved Hide resolved
@mkhuthir
Copy link
Author

mkhuthir commented May 8, 2019

This is a really great contribution, thank you! I just have a few comments / questions, please take a look. Also, should this go inside bash_tests/, or should we put it in tests/ or maybe tests/watson?

Thanks, tests/ seems good. I will change as you suggested.

@mkhuthir
Copy link
Author

Hello Justin. Any update ?

mkhuthir
mkhuthir commented Sep 27, 2019
View reviewed changes
Copy link
Author

@mkhuthir mkhuthir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls let me know if further changes are required, otherwise please approve it.

@mkhuthir mkhuthir closed this Oct 1, 2019
@mkhuthir mkhuthir deleted the feature/bash_tests branch October 1, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jweisz jweisz jweisz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkhuthir @jweisz