Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbounded limiter in MSL 3.2.3 causes negative phi #1221

Closed
Mathadon opened this issue Oct 19, 2019 · 5 comments · Fixed by #1222
Closed

Unbounded limiter in MSL 3.2.3 causes negative phi #1221

Mathadon opened this issue Oct 19, 2019 · 5 comments · Fixed by #1222
Assignees

Comments

@Mathadon
Copy link
Member

Since MSL 3.2.3 the model Modelica.Blocks.Nonlinear.Limiter has the parameter homotopyType, which sets a homotopy option. By default linear is used, which neglects the min/max bounds. When updating IDEAS to Dymola 2020 this caused the PI controller output bounds to be ignored at initialization, leading to a PI outlet control signal of -10, which then fed into a valve and caused the resulting algebraic loop not to converge due to the negative control signal. I propose to disable homotopy by default in IBPSA.Controls.Continuous.LimPID to avoid this.

@Mathadon Mathadon self-assigned this Oct 19, 2019
@Mathadon
Copy link
Member Author

@damienpicard this can explain convergence problems in your model too

Mathadon added a commit that referenced this issue Oct 19, 2019
This was referenced Oct 19, 2019
@mwetter
Copy link
Contributor

mwetter commented Oct 21, 2019

Disabling homotopy makes sense in this situation.

@Mathadon
Copy link
Member Author

Mathadon commented Oct 21, 2019

many models seem to be bugging out though.. I'll look into it.

edit: @mwetter does IBPSA already use Dymola2020 for the regression tests? It seems to have a newer version of MSL 3.2.3. The old version does not yet have this parameter and may be causing the models to fail for that reason.

@Mathadon
Copy link
Member Author

Mathadon commented Nov 7, 2019

@mwetter does IBPSA already use Dymola2020 for the regression tests? It seems to have a newer version of MSL 3.2.3. The old version does not yet have this parameter and may be causing the models to fail for that reason.

@mwetter
Copy link
Contributor

mwetter commented Nov 7, 2019

@Mathadon : IBPSA is using Dymola 2020 for the regression tests.

Mathadon added a commit that referenced this issue Nov 18, 2019
mwetter added a commit that referenced this issue Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants