-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbounded limiter in MSL 3.2.3 causes negative phi #1221
Comments
@damienpicard this can explain convergence problems in your model too |
Disabling homotopy makes sense in this situation. |
many models seem to be bugging out though.. I'll look into it. edit: @mwetter does IBPSA already use Dymola2020 for the regression tests? It seems to have a newer version of MSL 3.2.3. The old version does not yet have this parameter and may be causing the models to fail for that reason. |
@mwetter does IBPSA already use Dymola2020 for the regression tests? It seems to have a newer version of MSL 3.2.3. The old version does not yet have this parameter and may be causing the models to fail for that reason. |
@Mathadon : IBPSA is using Dymola 2020 for the regression tests. |
Since MSL 3.2.3 the model
Modelica.Blocks.Nonlinear.Limiter
has the parameterhomotopyType
, which sets a homotopy option. By defaultlinear
is used, which neglects the min/max bounds. When updating IDEAS to Dymola 2020 this caused the PI controller output bounds to be ignored at initialization, leading to a PI outlet control signal of -10, which then fed into a valve and caused the resulting algebraic loop not to converge due to the negative control signal. I propose to disable homotopy by default inIBPSA.Controls.Continuous.LimPID
to avoid this.The text was updated successfully, but these errors were encountered: