-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disabled homotopy for #1221 #1222
Conversation
… into issue1221_limiterHomotopy
This reverts commit 17cb3fe.
@mwetter Only now I realize that only the JModelica unit tests are failing. Any chance that they are not yet using the latest version of MSL that includes the homotopy option? |
@Mathadon : It looks like JModelica is not yet using the latest MSL that has the homotopy option. |
Not sure how to best approach that? It would make sense to use the same MSL version for the testing of the library. Alternatively we can duplicate the implementation of the model that was changed in the latest MSL release. |
@Mathadon : The current JModelica trunk uses MSL 3.2.2, as does OMEdit, but the new limiter is from 3.2.3. |
@mwetter done. I did not exactly copy the implementation since this would require me to also copy |
closes #1221