Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #1373. It utilizes functions to implement the two methods of determining the solar azimuth (with and without events) in a one-line if-statement. Therefore, it:
IBPSA.BoundaryConditions.SolarGeometry.BaseClasses.SolarAzimuthNoEvent
andIBPSA.BoundaryConditions.SolarGeometry.BaseClasses.SolarAzimuthWithEvent
IBPSA.BoundaryConditions.SolarGeometry.BaseClasses.SolarAzimuth
@Mathadon Our original implementation idea (06b0389) re-introduced state events into the simulations. Therefore, this is a different implementation that achieves the desired results: no events and
lat
not becoming a structural parameter with JModelica.org. Can you please review? Then, we can ask for outside review before merging.