Use unsigned for the parameter of the PropertyActivate message.

unsigned would be better since the Python binding and engine proxy use unsigned for this purpose. BUG=none TEST=ran Chrome for Chrome OS. Review URL: http://codereview.appspot.com/3660041
ibus · Dec 15, 2010 · ed778cd · ed778cd
1 parent 2ce1bd0
commit ed778cd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/bus/inputcontext.c b/bus/inputcontext.c
@@ -847,8 +847,8 @@ _ic_property_activate (BusInputContext       *context,
                        GDBusMethodInvocation *invocation)
 {
     gchar *prop_name = NULL;
-    gint prop_state = 0;
-    g_variant_get (parameters, "(&si)", &prop_name, &prop_state);
+    guint prop_state = 0;
+    g_variant_get (parameters, "(&su)", &prop_name, &prop_state);
 
     if (context->enabled && context->engine) {
         bus_engine_proxy_property_activate (context->engine, prop_name, prop_state);

diff --git a/src/ibusinputcontext.c b/src/ibusinputcontext.c
@@ -774,12 +774,12 @@ ibus_input_context_set_capabilities (IBusInputContext   *context,
 void
 ibus_input_context_property_activate (IBusInputContext *context,
                                       const gchar      *prop_name,
-                                      gint32            state)
+                                      guint32           state)
 {
     g_assert (IBUS_IS_INPUT_CONTEXT (context));
     g_dbus_proxy_call ((GDBusProxy *) context,
                        "PropertyActivate",                  /* method_name */
-                       g_variant_new ("(si)",
+                       g_variant_new ("(su)",
                                 prop_name, state),          /* parameters */
                        G_DBUS_CALL_FLAGS_NONE,              /* flags */
                        -1,                                  /* timeout */

diff --git a/src/ibusinputcontext.h b/src/ibusinputcontext.h
@@ -196,7 +196,7 @@ void         ibus_input_context_set_capabilities
 void         ibus_input_context_property_activate
                                             (IBusInputContext *context,
                                              const gchar      *prop_name,
-                                             gint32            state);
+                                             guint32           state);
 
 /**
  * ibus_input_context_focus_in: